Skip to content

[Fix #624] Correct default values when ActiveRecord::Enum is used #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

sashabelozerov
Copy link
Contributor

Fixes #624

Note: I was not able to reproduce the issue with gem enumerize (https://github.com/brainspec/enumerize), however it is reproducible with ActiveRecord::Enum.

@sashabelozerov sashabelozerov force-pushed the fix-enum-default-values branch from 10b4b34 to 8ca6d0f Compare October 26, 2019 15:20
@sashabelozerov sashabelozerov force-pushed the fix-enum-default-values branch from 8ca6d0f to 393380d Compare October 26, 2019 15:41
@ctran ctran added this to the v3.1.0 milestone Nov 9, 2019
@ctran ctran merged commit a4be28a into ctran:develop Nov 9, 2019
peterfication pushed a commit to store2be/annotate_models that referenced this pull request Jan 20, 2020
@drwl drwl removed this from the v3.1.0 milestone Feb 25, 2020
drwl added a commit that referenced this pull request Feb 29, 2020
drwl added a commit that referenced this pull request Feb 29, 2020
drwl added a commit that referenced this pull request Feb 29, 2020
drwl added a commit that referenced this pull request Feb 29, 2020
drwl added a commit that referenced this pull request Feb 29, 2020
drwl added a commit that referenced this pull request Feb 29, 2020
drwl added a commit that referenced this pull request Mar 8, 2020
It was reported in #762 that column defaults were broken. This reverts changes made in #677 to restore the expected behavior of column defaults. 

For the time being columns with associated enums won't be working.
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
It was reported in ctran#762 that column defaults were broken. This reverts changes made in ctran#677 to restore the expected behavior of column defaults. 

For the time being columns with associated enums won't be working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation puts wrong default value when we use Enumerize
3 participants