Skip to content

analyzer/test/file_system/physical_resource_provider_test is flaky #25472

Open
@scheglov

Description

@scheglov

Watch tests are flaky - sometimes it takes more than 1 second to get notification, or they never come. We don't know for sure.

@@@BUILD_STEP pkg tests failures@@@

FAILED: none-vm-checked release_ia32 pkg/analyzer/test/file_system/physical_resource_provider_test
Expected: Pass 
Actual: RuntimeError
CommandOutput[vm]:

stdout:
unittest-suite-wait-for-done
PASS: PhysicalResourceProviderTest | test_getStateLocation_uniqueness
PASS: PhysicalResourceProviderTest | test_watchFile_delete
PASS: PhysicalResourceProviderTest | test_watchFile_modify
FAIL: PhysicalResourceProviderTest | test_watchFolder_createFile
  Expected: non-empty
    Actual: []

  package:unittest/src/simple_configuration.dart 128:34                     SimpleConfiguration.onExpectFailure
  package:unittest/src/simple_configuration.dart 24:13                      _ExpectFailureHandler.fail
  package:unittest/src/matcher/expect.dart 121:5                            DefaultFailureHandler.failMatch
  package:unittest/src/matcher/expect.dart 95:20                            expect
  pkg/analyzer/test/file_system/physical_resource_provider_test.dart 339:9  PhysicalResourceProviderTest.test_watchFolder_createFile.<fn>.<fn>
  dart:async/future.dart 228                                                Future.Future.delayed.<fn>
  dart:async/zone.dart 903                                                  _rootRun
  dart:async/zone.dart 802                                                  _CustomZone.run
  dart:async/zone.dart 708                                                  _CustomZone.runGuarded
  dart:async/zone.dart 733                                                  _CustomZone.bindCallback.<fn>
  dart:async/zone.dart 907                                                  _rootRun
  dart:async/zone.dart 802                                                  _CustomZone.run
  dart:async/zone.dart 708                                                  _CustomZone.runGuarded
  dart:async/zone.dart 733                                                  _CustomZone.bindCallback.<fn>
  dart:async-patch/timer_patch.dart 16                                      Timer._createTimer.<fn>
  dart:isolate-patch/timer_impl.dart 385                                    _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414                                    _Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148                                 _RawReceivePortImpl._handleMessage
PASS: PhysicalResourceProviderTest | test_watchFolder_deleteFile
PASS: PhysicalResourceProviderTest | test_watchFolder_modifyFile
PASS: PhysicalResourceProviderTest | test_watchFolder_modifyFile_inSubDir
PASS: FileTest | test_createSource
PASS: FileTest | test_equals_differentPaths

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2A bug or feature request we're likely to work onanalyzer-technical-debtanalyzer-testarea-dart-modelFor issues related to conformance to the language spec in the parser, compilers or the CLI analyzer.type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions