Skip to content

Add assert for _FutureListener.handleValue receiver stack position #44657

Open
@ghost

Description

8f2c47f relies on the assumption that the receiver to _FutureListener.handleValue is at a fixed offset in the calling frame, but this assumption is not tested or guaranteed.

@mraleph suggested:

[add] checks when generating code for the handleValue itself.
e.g. [...] add a check in linearscan.cc that ParameterInstr for this is allocated into the right place on the stack when compiling handleValue body.
And similar check into LoadLocalInstr for unoptimized compilation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.vm-technical-debtThis label tries to capture all the technical debt that we have accumulated in the Dart VM

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions