Skip to content

Loosen StoreIndexedInstr::MakeLocationSummary RAX requirement #48623

Open
@ghost

Description

// TODO(fschneider): Add location constraint for byte registers (RAX,
// RBX, RCX, RDX) instead of using a fixed register.
locs->set_in(2, LocationFixedRegisterOrSmiConstant(value(), RAX));

The above RAX restriction is potentially no longer needed as of https://dart-review.googlesource.com/c/sdk/+/237690.
Dart's x64 assembly used not be able to express movs to byte registers above the first four, but after the above fix that is no longer the case.

We should check whether there are any other blockers and otherwise remove this TODO.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.vm-technical-debtThis label tries to capture all the technical debt that we have accumulated in the Dart VM

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions