Skip to content

[infra] fix flag validation in test_runner #53948

Open
@sigmundch

Description

@sigmundch

Recently the test_runner started validating that we don't override a flag that is implied by the named configuration. The previous validation was accidentally omitted until https://dart-review.googlesource.com/c/sdk/+/333842.

This broke the macos web bots because they need to specify the arch option when running test.py. Otherwise, the sharding infrastructure failed to properly run the tests in the correct architecture.

To keep some validation, but continue to allow the bots to operate, I am temporarily skipping the check for the arch flag. Ideally we should be able to add it back, by fixing how the sharding works.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-infrastructureUse area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions