baseUrl has the wrong value because app path has "/test/" in it

[mdebbar]

Here is the relevant code that was copied to dwds. Here is the code in dwds:

webdev/dwds/lib/src/loaders/require.dart

Lines 36 to 46 in 3ad544e

	const _baseUrlScript = '''
	var baseUrl = (function () {
	// Attempt to detect --precompiled mode for tests, and set the base url
	// appropriately, otherwise set it to '/'.
	var pathParts = location.pathname.split("/");
	if (pathParts[0] == "") {
	pathParts.shift();
	}
	if (pathParts.length > 1 && pathParts[1] == "test") {
	return "/" + pathParts.slice(0, 2).join("/") + "/";
	}

We got a report from a user seeing this issue (and I was able to reproduce it, too): flutter/flutter#116360 (comment)

Basically, their app has a path "/sample_item/test/", it trips the generated bootstrap code into thinking that it's in test mode, and it calculates the wrong baseUrl.

[jakemac53]

I didn't think flutter was still using build_web_compilers?

[mdebbar]

I didn't think flutter was still using build_web_compilers?

Hmmm.. I'm not sure. We do generate main_module.bootstrap.js here:
https://github.com/flutter/flutter/blob/dff09558d3fa6fa22253708df5072fbed9c656c9/packages/flutter_tools/lib/src/web/bootstrap.dart#L154

But when the file gets served by the web server, I see more content appended to the file. That extra content is exactly the same as this var baseUrl = ... in build_web_compilers. I also see code from here being appended.

I don't see a direct dependency on build_web_compilers here. Is it possible that this dependency is being pulled transitively? Or DDC uses it internally?

Note: This only happens in debug mode (using DDC).

cc @jonahwilliams who may have some extra context.

[jonahwilliams]

We don't use build_web_compilers, but some of the flutter tool code was taken from bwc initially

[jakemac53]

Ok, so probably the fix needs to be in the flutter tool code which was originally taken from bwc. I am not really sure what the right fix is here, or if that logic is even relevant for flutter web.

[jakemac53]

I don't think I am going to bother fixing it in bwc unless somebody files an issue as I think this is probably pretty uncommon.

[mdebbar]

Thanks @jakemac53 and @jonahwilliams. I transferred the issue to the webdev repo (where dwds lives).

[annagrin]

@mdebbar thanks for filing the issue! I'll take a look.