Test everything #48
Merged
Test everything #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honno
force-pushed
the
test-everything
branch
from
cc6c052 to
ebb8160
Compare
honno
force-pushed
the
test-everything
branch
from
ebb8160 to
f108941
Compare
|
Also fixes #50 |
|
@asmeurer This PR makes significant changes to the manip and stat functions of #39, so I've closed that as it doesn't make sense to review such out-dated and somewhat erroneous code. I'm also now ready for review/happy for merging. (IMO we should take the approach that I should just merge my large PRs if you can't review them to a satisfactory standard after a few days + there are no glaring issues. If that was the case I'd be incentivised to make more atomic PRs anywho, so when I inevitably screw something up it'll be easier to identify where I went wrong heh.) |
|
Yes, it would be OK with me if you do more self merging. I'm not able to review such large PRs in detail in a reasonable amount of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should finishing testing every function in the spec 🎉
Starts from #39. Currently just implements searching tests.Covers everything from the now-closed #39, and finishes out the rest.I'd rather do this all in one go as 1) I'd rather not further chain PRs 2) I'm gunna want to refactor some utils.