Add clarifying examples to note concerning tuple usage in multi-axis indexing #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
Narrative Content
asmeurer
approved these changes
Oct 4, 2021
honno
reviewed
Oct 4, 2021
|
@asmeurer You mind giving this another review, as I made some additional changes? |
asmeurer
reviewed
Oct 7, 2021
|
As this PR does not include any breaking changes and simply clarifies existing specification behavior, will merge. Any further changes not included in this PR can be addressed in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
x[(i,)]#257 by expanding the note regarding tuple usage for multi-axis indexing. Notably, the added examples include a one-element tuple example demonstrating the equivalence with a single-axis index.