Skip to content

Fix erroneous updates to arange intended for linspace #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2022
Merged

Fix erroneous updates to arange intended for linspace #421

merged 4 commits into from
Apr 25, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Apr 21, 2022

This PR

@kgryte kgryte added bug Something isn't working. topic: Creation Array creation. labels Apr 21, 2022
@kgryte kgryte requested a review from honno April 21, 2022 16:45
@kgryte kgryte added this to the v2021 milestone Apr 21, 2022
honno
honno requested changes Apr 22, 2022
View reviewed changes
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one comment. Sorry I didn't catch this last time 😅

@kgryte @honno
Add linebreaks
7491a49 
Co-authored-by: Matthew Barber <[email protected]>
@kgryte
Copy link
Contributor Author

kgryte commented Apr 25, 2022

Thanks, @honno! Will merge...

@kgryte kgryte merged commit 416b71a into main Apr 25, 2022
@kgryte kgryte deleted the fix-arange-linspace branch April 25, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honno honno honno requested changes

Assignees
No one assigned
Labels
bug Something isn't working. topic: Creation Array creation.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @honno