-
Notifications
You must be signed in to change notification settings - Fork 53
Add device
keyword to fftfreq and rfftfreq
#506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we mention that only inexact data types, i.e. "real floating" and "complex floating" are expected to be supported? |
@oleksandr-pavlyk Updated the PR to require that |
This change matches the discussion. |
@rgommers I was thinking the same thing. The |
As discussed in our previous meeting, we are not going to add |
Found a previous issue on the NumPy issue tracker (numpy/numpy#9126) raised by @jakirkham concerning supporting a |
dtype
and device
to fftfreq and rfftfreqdtype
and~ device
to fftfreq and rfftfreq
dtype
and~ device
to fftfreq and rfftfreqdevice
keyword to fftfreq and rfftfreq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this addresses gh-500 by adding the needed device
keyword.
The dtype
discussion seems to be of theoretical interest, but - given that no library actually implement it - of very limited practical value. Let's punt on that; if anyone actually needs it, let them implement it at least in numpy
first.
This PR,
device
as arguments tofftfreq
device
as arguments torfftfreq
This PR fixes #500