Skip to content

Fix version menu bug #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 9, 2023
Merged

Fix version menu bug #650

merged 18 commits into from
Jul 9, 2023

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jul 8, 2023 •
edited
Loading

This PR

  • refactors version menu logic to use async/await.
  • refactors the implementation to accommodate when a resource path does not have expected path segments.
  • adds JSDoc comments to clarify callback intent
  • reduces network traffic by performing a HEAD request rather than a full GET. This addresses the intent of gh-628, but in that PR, a full GET request is made.

@kgryte kgryte added the Maintenance Bug fix, typo fix, or general maintenance. label Jul 8, 2023
@kgryte kgryte merged commit 2e0c414 into data-apis:main Jul 9, 2023
@kgryte kgryte deleted the fix-version-menu-bug2 branch July 9, 2023 02:55
@kgryte kgryte mentioned this pull request Jul 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kgryte