-
Notifications
You must be signed in to change notification settings - Fork 53
Clean up some wording in the fft extension #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
c51ce80
Use better wording for the return dtypes for fft functions
asmeurer 1dd9757
Specify the output shapes for fft functions
asmeurer bde524e
Fix typo for rfft return dtype
asmeurer 1fd3429
Add specification for computing the cumulative sum
kgryte bda9c48
Add note clarifying behavior for out-of-bounds indices in `take`
kgryte 50ca679
Add specifications for `maximum` and `minimum`
kgryte 5c2423a
Fix definition of complex inner product in `vecdot` (#723)
mtsokol 3295776
Update fft, ifft, fftn, ifftn, and hfft to only accept complex inputs
asmeurer 72f86f3
Add `searchsorted` to the specification (#699)
kgryte 8fe8b08
Fix sidebar contents under Extensions (#729)
rgommers 7a56675
Update DLPack content to address unsupported use cases (#709)
rgommers 7c3f99a
Backport fft language improvements to 2022.12
asmeurer 62f95fd
Fix typo for hfft return dtype
asmeurer 6e320d0
Add `clip` to the specification
kgryte 0cde841
Clarify guidance in the "function and method signatures" section
rgommers 293512d
Upgrade Sphinx version used in doc deployment (#735)
rgommers 95332bb
Fix wording for comparison operators
hameerabbasi e9988f2
Fix the text for the output shape for (i)rfft(n)
asmeurer 22fc23a
Add Optional type annotation for some parameters that can be None
asmeurer d4eebdf
back port optional type annotation
leofang 86cc351
nits
leofang c4df0be
sync 2022 and draft
leofang 6a2d6d0
nit: length of array "along" axis
leofang 4d6e519
mention untransformed axes & align style
leofang 35f2ea4
no more m
leofang a84c293
separately list the condition when s/n is None
leofang 029afcd
Update language to be consistent with existing specification conventions
kgryte 17124ba
Merge branch 'fft-fixes' of https://github.com/asmeurer/array-api int…
kgryte 6d9fac4
Update copy for `fft`
kgryte 66e9e29
Update copy
kgryte 99cb776
Update copy for `ifft`
kgryte 04a4e66
style: satisfy linting
kgryte 9f208f6
Update copy for `fftn`
kgryte 9a6fcc7
Update copy for `ifftn`
kgryte 454ded7
Update copy
kgryte 21e2840
Update copy for `rfft`
kgryte 22d354a
Update copy for `irfft`
kgryte 4d0160c
Update copy for `rfftn`
kgryte 9d90326
Update copy for `irfftn`
kgryte 8f2b6df
Update copy for `hfft`
kgryte 43e96fa
Update copy for `ihfft`
kgryte c180034
Update copy
kgryte 9f1c20e
Copy changes over to draft specification
kgryte b97bb34
Update copy
kgryte 0a7df55
Fix indentation
kgryte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.