Skip to content

PR: Add metadata attribute to DataFrame and Column #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

PR: Add metadata attribute to DataFrame and Column #43

wants to merge 6 commits into from

Conversation

steff456
Copy link
Member

This PR adds a metadata attribute that can be used to store library-specific things. For example, libraries like Vaex will be able to store expressions for its virtual columns there.

  • Add metadata attribute to the DataFrame class
  • Add metadata attribute to the Column class
  • Add a test

@steff456 steff456 requested a review from rgommers June 23, 2021 22:00
@steff456 steff456 self-assigned this Jun 23, 2021
rgommers
rgommers reviewed Jun 25, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456!

The added signatures look good, I propose a few tweaks to docs and the Pandas prototype.

This was referenced Jun 25, 2021
Open
Merged
@rgommers rgommers added enhancement New feature or request interchange-protocol labels Jun 25, 2021
rgommers
rgommers approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456, merged in commit d9419b1.

@rgommers rgommers closed this Aug 23, 2021
@rgommers rgommers mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@rgommers rgommers rgommers approved these changes

Assignees

@steff456 steff456

Labels
enhancement New feature or request interchange-protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steff456 @rgommers @kgryte