Skip to content

[common/meta] refactor: move async-raft to datafuselabs/openraft #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 29, 2021
Merged

[common/meta] refactor: move async-raft to datafuselabs/openraft #3685

merged 3 commits into from
Dec 29, 2021

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Dec 28, 2021 •
edited by BohuTANG
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

[common/meta] refactor: move async-raft to datafuselabs/openraft

Changelog

  • Improvement

Related Issues

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 28, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/2citEmZfmCGW4YkVMnkPPgo1fZ9h
✅ Preview: Canceled

[Deployment for 1a17091 canceled]

@drmingdrmer drmingdrmer marked this pull request as ready for review December 28, 2021 18:27
ariesdevil
ariesdevil approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice shot

@BohuTANG
Copy link
Member

The CI is broken, wait it work again :\

@BohuTANG
Copy link
Member

Does the openraft will be published as crate in the future? (cc @drmingdrmer )

@drmingdrmer
Copy link
Member Author

Does the openraft will be published as crate in the future? (cc @drmingdrmer )

It's an option indeed.

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@BohuTANG
Copy link
Member

The ci failure is not related to this PR, let's merge 🚀

@BohuTANG BohuTANG merged commit a2529db into databendlabs:main Dec 29, 2021
@drmingdrmer drmingdrmer deleted the raft branch December 29, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariesdevil ariesdevil ariesdevil approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@lichuang lichuang Awaiting requested review from lichuang

Assignees
No one assigned
Labels
need-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drmingdrmer @databend-bot @BohuTANG @ariesdevil