Fix for malformed query leading to CLI hanging. #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pensivebrian
requested changes
Jan 11, 2018
| yield self.tabular_results_generator(column_info=None, result_rows=None, | ||
| query=query, message=query_response.error_message, | ||
| is_error=True) | ||
| elif isinstance(query_response, queryservice.QueryMessageEvent): |
There was a problem hiding this comment.
We are we deleting this? We need it to hamdle Error response events #Closed
There was a problem hiding this comment.
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
* Fixing queryexecution service to handle error during query execution. * Fixing format of for statement. * Fixing pep8 space after comma. * Adding 2 second sleep after connection. * Adding regression test. * Updating baseline. * Fixing baseline.
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
* Fixing queryexecution service to handle error during query execution. * Fixing format of for statement. * Fixing pep8 space after comma. * Adding 2 second sleep after connection. * Adding regression test. * Updating baseline. * Fixing baseline.
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
* Fixing queryexecution service to handle error during query execution. * Fixing format of for statement. * Fixing pep8 space after comma. * Adding 2 second sleep after connection. * Adding regression test. * Updating baseline. * Fixing baseline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A query execute string request would not mark itself as finished when receiving a query execute error response event, leaving mssqlcliclient infinitely looping for a response.
If a error is returned during execute_single_batch_query, immediately return rather.
Fix for #136