Add special commands and tests #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pensivebrian
reviewed
Feb 2, 2018
tests/test_special.py
Outdated
| try: | ||
| # create the database objects to test upon | ||
| client = create_mssql_cli_client() | ||
| list(client.execute_single_batch_query('CREATE DATABASE testdb1;')) |
There was a problem hiding this comment.
testdb1 [](start = 68, length = 7)
can this by dynamic, eg. mssql-cli-test-xxxx-xxxxx
This way, concurrently running tests can't step on each other. #Resolved
pensivebrian
reviewed
Feb 2, 2018
tests/test_special.py
Outdated
| @@ -0,0 +1,86 @@ | |||
| import unittest | |||
|
|
|||
There was a problem hiding this comment.
please run these test on supported server version to make sure the queries work: 2005, 2008, 2012, 2016, 2017, and Azure SQLDB, Azure SQL DW #Resolved
There was a problem hiding this comment.
tested (tested on 2005 manually, tests were timing out due to the issue we saw offline)
In reply to: 165537064 [](ancestors = 165537064)
pensivebrian
approved these changes
Feb 2, 2018
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
* Special commands create source files * Special commands add help special command * Add list databases command * Add list schemas special command * Add list tables * Add list views and list indexes * Add special command tests * Update tests to use dynamically generated resource names
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
* Special commands create source files * Special commands add help special command * Add list databases command * Add list schemas special command * Add list tables * Add list views and list indexes * Add special command tests * Update tests to use dynamically generated resource names
hejack0207
pushed a commit
to hejack0207/osql-cli
that referenced
this pull request
Apr 27, 2018
* Special commands create source files * Special commands add help special command * Add list databases command * Add list schemas special command * Add list tables * Add list views and list indexes * Add special command tests * Update tests to use dynamically generated resource names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the first batch of special commands, and the corresponding tests.
Code coverage bumped from 63% to 64%
More special commands will be added in separate PR's.
This PR gives a foundation for implementing future special commands.