Skip to content

remove calling of the idiot executeScriptTags #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove calling of the idiot executeScriptTags #479

wants to merge 1 commit into from

Conversation

dallaslu
Copy link

@dallaslu dallaslu commented Feb 4, 2015

fixes
#416
#478
#469
#331
#242

and there may be a lot more.

referenced
#446
#400
#257

@mislav
Copy link
Collaborator

mislav commented Feb 4, 2015

Doing so will disable us from using pjax on GitHub.com, where we have a CSP policy do disallow eval and thus can't afford to let jQuery load and eval scripts in sequence. More in the thread here which is among the ones you referenced: #331 (comment)

It will be hard to convince us to merge a change after which the maintainers ourselves will not be able to use the library on the site it was originally created for.

@dallaslu
Copy link
Author

dallaslu commented Feb 4, 2015

A key fact: once executeScriptTags is removed, everything will be OK.

There is non eval, and jQuery load and eval scripts should be in sequence, it just seems like not using pjax. If I am wrong, let me know.

@mislav
Copy link
Collaborator

mislav commented Feb 4, 2015

jQuery internally uses eval to execute both remote and inline script tags after they've been detected in content that's being inserted. On sites with CSP enabled, eval doesn't work and will result in a security exception. jQuery's feature won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants