Check for MariaDB Version when selecting users without passwords #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaDB Uses the authentication_string field since 10.4.0, added this in version check in query for users to delete Signed-off-by: Martin Neubert <[email protected]>
rndmh3ro
reviewed
Apr 28, 2021
There was a problem hiding this comment.
Thanks, looks good to me. Can you add the suggestions I added, please? I noticed that the task-names were wrong.
We need to write some tests for this!
Also checking the docs you linked, we probably can change our tests for mariadb >= 10.4 regarding the root user.
Co-authored-by: Sebastian Gumprich <[email protected]>
Co-authored-by: Sebastian Gumprich <[email protected]>
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
…-sec#444) * added version check for MariaDB in Query MariaDB Uses the authentication_string field since 10.4.0, added this in version check in query for users to delete Signed-off-by: Martin Neubert <[email protected]> * Update roles/mysql_hardening/tasks/mysql_secure_installation.yml Co-authored-by: Sebastian Gumprich <[email protected]> * Update roles/mysql_hardening/tasks/mysql_secure_installation.yml Co-authored-by: Sebastian Gumprich <[email protected]> Co-authored-by: Sebastian Gumprich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MariaDB uses the authentication_string field since 10.4.0, added this in version check in query for users to delete.
https://mariadb.com/kb/en/authentication-from-mariadb-104/
Without these changes, the role assumes 10.3 >= 5.7.6 and drops all users with empty authentication_string. Since authentication_string is not used in this versions (Password field is used, authentication_string is always empty), the role simply drops all users.