This repository was archived by the owner on Dec 26, 2020. It is now read-only.
rework CRYPTO_POLICY handling for fedora #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous implementation did not handle fedora right. Now we check if a CRYPTO_POLICY is present regardless of the OS version. Signed-off-by: Martin Schurz <[email protected]>
schurzi
commented
Jul 22, 2020
tasks/hardening.yml
Outdated
| path: /etc/sysconfig | ||
| pattern: sshd | ||
| contains: '.*CRYPTO_POLICY=.*' | ||
| register: crypto_policy |
There was a problem hiding this comment.
I found no better way of detecting if we have to disable the CRYPTO_POLICY, that also works with all supported OSes
Considered alternatives were:
- package_facts_module search for package
crypto-policies
Possible alternative, but maybe more ressource intensive. Also needs extra task but no register - OS version check
Would need to construct a check which covers CentOS/RHEL/Oracle and Fedora with differend release versions, that would be very complicated - some varaible from default facts
Nothing of value found there
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
rndmh3ro
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous implementation did not handle fedora right. Now we check if
a CRYPTO_POLICY is present regardless of the OS version.
Signed-off-by: Martin Schurz [email protected]