-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: update readme to indicate the port binding #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cd21ac9
docs: update readme to indicate the port binding
felipementel 7888988
Revert "docs: update readme to indicate the port binding"
felipementel e30121c
docs: update readme to indicate the port binding
felipementel a5c5a3f
docs: insert the instruction to access the sonarqube from local envir…
felipementel 5841cbf
Merge branch 'docker-library:master' into master
felipementel 26af880
Update sonarqube/content.md
felipementel fcb6ad2
Update sonarqube/content.md
felipementel 443ce1c
Update sonarqube/content.md
felipementel aabedf6
Update sonarqube/content.md
felipementel dd6fb63
Update sonarqube/content.md
felipementel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something like "By default, the server running within the container will listen on port 9000. You can expose the container port 9000 to the host port 9000 with the
-p 9000:9000
argument todocker run
:" would be more clear?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the text, like your suggestion.
I also will ajust the pull request like @tianon indicated.