Migrate current compose examples to PWD capable stacks #941
Conversation
|
cc image maintainers @TimWolla @doublebyte1 @mbabker @brianteeman -- extra eyes on your relevant parts (or the whole thing!) of this would be A+ appreciated 👍 ❤️ |
|
Looks fine to me. |
adminer/content.md
Outdated
| @@ -30,6 +30,10 @@ Then point your web server to port 9000 of the container. | |||
|
|
|||
| Note: This exposes the FastCGI socket to the Internet. Make sure to add proper firewall rules or use a private Docker network instead to prevent a direct access. | |||
|
|
|||
| ## %%STACK%% | |||
|
|
|||
| Run `docker stack deploy -c stack.yml %%REPO%%` (or `docker-compose -f stack.yml up`), wait for it to initialize completely, and visit `http://swarm-ip:8080`, `http://localhost:8080`, or `http://host-ip:8080` (as appropriate). | |||
There was a problem hiding this comment.
I'm not really sure whether this really provides a value-add for Adminer: Usually you would use an existing database, instead of creating a new one to use.
The online demo using this stack.yml works fine, from what I've seen though.
There was a problem hiding this comment.
I'm not really sure whether this really provides a value-add for Adminer: Usually you would use an existing database, instead of creating a new one to use.
@TimWolla thx for the feedback. What about people that just want to try it the first time to see if it'll suite their needs?. Another use-case is whenever the image gets updated you can just launch the new version with a single click to try new features.
IMHO the fact that you can just launch it with a single click and have it running without having to do anything at all is quite powerful.
There was a problem hiding this comment.
@marcosnils Is this paragraph required to the online demo?
In any case, I don't object this change, but this paragraph refers to a downloaded swarm.yml which IMO is unnecessary clutter for adminer.
|
Thanks. Looks good |
adminer/content.md
Outdated
| @@ -30,6 +30,10 @@ Then point your web server to port 9000 of the container. | |||
|
|
|||
| Note: This exposes the FastCGI socket to the Internet. Make sure to add proper firewall rules or use a private Docker network instead to prevent a direct access. | |||
|
|
|||
| ## %%STACK%% | |||
There was a problem hiding this comment.
This headline is either at the wrong position or of the wrong size.
|
@tianon @marcosnils This looks fine to me, Thanks! |
Added stack files for the current official images: