php-fpm pm.max_children too small

The current default setting too small, please increase it

pm.max_children = 5

Why not increase it to 50?
Yes. i know i can create my own conf to replace this. but i just want using official docker image, do not want to maintain my own php-fpm image

[blazarecki]

You can use volume to override the default configuration without having your own Dockerfile.

[tianon]

It's a pretty serious bummer that https://secure.php.net/manual/en/install.fpm.configuration.php#pm.max-chidlren doesn't give us any official recommendation on what a "sane" value should be. I'm really hesitant to change this since our current value is based on the default provided with the PHP distribution (

php/7.0/fpm/php-fpm.conf

Lines 1 to 2 in 85447ff

	; This file was initially adapated from the output of: (on PHP 5.6)
	; grep -vE '^;|^ *$' /usr/local/etc/php-fpm.conf.default

), and we try to stay as close to upstream and what they officially recommend as possible. That being said, that file was generated from PHP 5.6's defaults, so I think it's worth double-checking PHP 7.0 now and seeing if any of the defaults have been updated.

[tianon]

Heh, now I'm even more confused; thanks php-fpm:

$ docker run -it --rm php:7-fpm sh -c "grep -vE '^;|^ *$' /usr/local/etc/php-fpm.conf.default"
[global]
include=NONE/etc/php-fpm.d/*.conf

[tianon]

This looks slightly better, although makes me wonder if we need to update our approach to take advantage of this new-found include default: 😄

root@54227feee4bc:/var/www/html# grep -vE '^;|^ *$' /usr/local/etc/php-fpm.d/www.conf.default 
[www]
user = www-data
group = www-data
listen = 127.0.0.1:9000
pm = dynamic
pm.max_children = 5
pm.start_servers = 2
pm.min_spare_servers = 1
pm.max_spare_servers = 3

[tianon]

Closing since this behavior was adjusted slightly by #184, and because we're using default values provided by upstream. If they aren't appropriate for your use case, I'd recommend changing them or petitioning upstream to change the defaults (if you think your rationale is strong enough to convince them). Thanks!