Keep lib sources so the image can be used as a base image for postgis #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisbelson
changed the title
|
Seems fine to me, though |
|
Cool ! I updated |
|
Comparison of size difference: $ # current:
postgres 9.6-alpine c4d8fd02c94a 12 days ago 33.94 MB
$ # new
postgres 9.6-alpine 8a31e85fae3e 20 seconds ago 37.69 MB |
yosifkit
approved these changes
Jan 17, 2017
|
Seems fair to me! 👍 |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jan 27, 2017
- `bash`: 4.4.12 - `golang`: 1.7.5, 1.8rc3 - `mysql`: add automatic SSL support matching upstream behavior (docker-library/mysql#259) - `openjdk`: debian 9~b154-1 - `php`: auto-create `APACHE_RUN_DIR` and `APACHE_LOCK_DIR` at runtime if necessary (docker-library/php#330) - `postgres`: keep `include` for building against (docker-library/postgres#247) - `rabbitmq`: add Alpine variant (docker-library/rabbitmq#137) - `wordpress`: 4.7.2
This was referenced Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless there's a way to only install the source headers from the postgres source, it's impossible to use this image as a base image for postgis because they are missing. It only adds 3 MB of data to the image to keep them: