Skip to content

Update permissions from 777 to 1777 #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

tianon
Copy link
Member

@tianon tianon commented Mar 11, 2023

This still supports the "arbitrary user" use case but with slightly tighter permissions on the end result.

This still supports the "arbitrary user" use case but with slightly tighter permissions on the end result.
@lukebakken lukebakken self-assigned this Mar 11, 2023
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious what prompted this change?

@tianon
Copy link
Member Author

tianon commented Mar 13, 2023

I'm just curious what prompted this change?

Not really one specific thing, but over the years many, many users complaining about the "insecure" permissions on directories like these (I made PRs like this across all the images maintained under https://github.com/docker-library at the same time 😅), and this change providing slightly better permissions while still being inline with the original intent (and being very unlikely to break people). 😇

@tianon
Copy link
Member Author

tianon commented Mar 13, 2023

(Also, a means of procrastinating another change to a totally different image's Dockerfile when I noticed the 777 that one had and letting myself get distracted making this change everywhere instead 😂)

@lukebakken lukebakken merged commit fb984f6 into docker-library:master Mar 14, 2023
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 14, 2023
Changes:

- docker-library/rabbitmq@fb984f6: Merge pull request docker-library/rabbitmq#620 from infosiftr/1777
- docker-library/rabbitmq@608d785: Update permissions from 777 to 1777
@yosifkit yosifkit deleted the 1777 branch March 15, 2023 04:13
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 17, 2023
Changes:

- docker-library/rabbitmq@ca55cfc: Update 3.12-rc to 3.12.0-beta.2
- docker-library/rabbitmq@fb984f6: Merge pull request docker-library/rabbitmq#620 from infosiftr/1777
- docker-library/rabbitmq@608d785: Update permissions from 777 to 1777
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 20, 2023
Changes:

- docker-library/rabbitmq@7e15b7d: Update 3.11 to 3.11.11
- docker-library/rabbitmq@ca55cfc: Update 3.12-rc to 3.12.0-beta.2
- docker-library/rabbitmq@fb984f6: Merge pull request docker-library/rabbitmq#620 from infosiftr/1777
- docker-library/rabbitmq@608d785: Update permissions from 777 to 1777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants