-
Notifications
You must be signed in to change notification settings - Fork 333
Add 2.5-rc builds #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2.5-rc builds #165
Conversation
e6bbef0
to
b1453dd
Compare
Now CI is passed 💚 |
We should ditch Also, I'm not so sure about adding If bundler was not included and is now, I wonder if perhaps for 2.5+ we should stop installing our own version and just let whatever comes with Ruby stay (especially since as written, our final image will end up with two copies of bundler since the reinstall happens in a later layer). |
Bundler is default gem since Ruby 2.5. https://www.ruby-lang.org/en/news/2017/10/10/ruby-2-5-0-preview1-released/ I add
I think we should do as same as rubygems. ruby/Dockerfile-debian.template Line 60 in 59abfdf
So specifying bundler version and re-installing makes sense to me.
So then, what do you think about inlining?
|
Ok, fair enough -- moving that inline like our "rubygems" force update
makes sense then. Thanks!
|
@tianon Updated! |
Thanks! |
- `ghost`: 1.15.1 - `kibana`: 5.6.3 (oops) - `logstash`: 5.6.3 (oops) - `mariadb`: resync config fixes (MariaDB/mariadb-docker#133) - `mysql`: fix config issues (docker-library/mysql#336) - `percona`: resync config fixes, `MYSQL_ROOT_HOST` (docker-library/percona#51) - `ruby`: 2.5.0-preview1 (docker-library/ruby#165)
As of RubyGems 2.7.0 (released last month), Bundler is now a default (aka "vendored") gem. As a result we need to either accept the default bundler gem or explicitly force our own using `gem install --force`. I'm taking the latter approach because I believe it's less brittle for Docker images that depend on this one. Specifically, once we've installed *one* version of the bundler gem, subsequent `gem install bundler` calls will work without `--force`. So, if a dependent Dockerfile includes a step `RUN gem install bundler`, that should continue to work without error. Also, this is the approach taken by the docker-library/ruby image. See also: rubygems/rubygems#2058 docker-library/ruby#165
Please merge docker-library/official-images#3606 first 🙏
Current test suite is failed because of removing mathn.rb from stdlib since Ruby 2.5
Ruby 2.5.0-preview1 is released.
https://www.ruby-lang.org/en/news/2017/10/10/ruby-2-5-0-preview1-released/
I ran following commands to create them: