-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix #1118 #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1118 #1121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for ur input, feel free to make it better .:+1:
@Koooooo-7 Sorry, I still keep my opinion. |
@sy-records yep, I will look on it also. @anikethsaha could u review this PR about those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const matchContent =
'...' +
escapeHtml(postContent)
.substring(start, end)
.replace(regEx, `<em class="search-keyword">${keyword}</em>`) +
'...';
and I think u need consider on this place together also.
Is there any problem here? |
nah, cuz we don't have good test now, so I hope u could make sure the changes about all the |
Well, I tried it without problems. |
okay, thx again. |
please , squash the commits (with clearly commit message) then we are good to merge. 👍 |
@Koooooo-7 we can do squash and merge while merging, we will add an appropriate message for it according to our commit message convention. I am waiting for @trusktr 's review, we can merge this after 2-3 days if he is in-active . |
Summary
fix #1118
This modification will ensure that the search content and body rendering are consistent.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
lib
directory.