Skip to content

Bucket Sort implementation #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Bucket Sort implementation #25

merged 2 commits into from
Feb 6, 2022

Conversation

tuqqu
Copy link
Contributor

@tuqqu tuqqu commented Nov 12, 2021

Description

Bucket Sort implementation.

Related Issue

Motivation and Context

How Has This Been Tested?

Tests are done similarly to the existing tests for sorting algorithms.

Screenshots (if appropriate):

@tuqqu
Copy link
Contributor Author

tuqqu commented Feb 6, 2022

@doganoo Hi! Is there anything that needs to be done before this PR is merged?

Copy link
Owner

@doganoo doganoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuqqu Thank you for contributing to PHPAlgorithms! Please excuse my late reply, I was a bit busy with projects :-)

There is just a simple small change - could you please add your own name to the file header?

/**
* MIT License
*
* Copyright (c) 2018 Dogan Ucar
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add your own name here?

@tuqqu
Copy link
Contributor Author

tuqqu commented Feb 6, 2022

No worries! Added an author tag to the file.

@doganoo
Copy link
Owner

doganoo commented Feb 6, 2022

👍👍 thanks. Will merge the PR and tag ASAP

@doganoo doganoo merged commit 78152f0 into doganoo:master Feb 6, 2022
@tuqqu tuqqu deleted the bucket_sort branch February 7, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants