Warn on DNS lookup failures #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I experienced that error while doing tests using docker. Nice to have this change. One question: will the retry handle by the client or need to be handled by application? |
|
Retries should happen as with any other connection failure. Which means that for metadata requests, the retries will happen transparently. Consumer fetches should also retry transparently. For produce requests, the batch will use the |
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 25, 2017
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Oct 6, 2017
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrokerConnection currently raises a socket exception if dns resolution of broker metadata fails. This error is typically unhandled by application code and causes a hard crash. In many cases, this error is recoverable after short delay (temporary dns infrastructure problems) and/or refresh metadata (configuration errors). This PR changes the response to dns lookup errors to no longer raise an exception and instead just log a warning.