Minor Exception cleanup #1317
Merged
Minor Exception cleanup #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
commented
Dec 7, 2017
| if tags is not None and not isinstance(tags, dict): | ||
| raise Exception('tags must be a dict if present.') | ||
| raise ValueError('tags must be a dict if present.') |
There was a problem hiding this comment.
Alternatively, both of these could be changed to KafkaConfigurationError
| log.exception('StopIteration raised unpacking messageset: %s', e) | ||
| raise Exception('StopIteration raised unpacking messageset') | ||
| log.exception('StopIteration raised unpacking messageset') | ||
| raise RuntimeError('StopIteration raised unpacking messageset') |
There was a problem hiding this comment.
Potentially this should be a KafkaError although I'm unclear when to reach for that instead of RuntimeError
There was a problem hiding this comment.
RuntimeError is what would be raised by the convention on Python3 if we have a not handled StopIteration raised inside of a generator, so seems fine to me
jeffwidman
force-pushed
the
minor-exception-cleanup
branch
from
96b9ca2 to
43511aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.