Skip to content

Check against basestring instead of str in collect.hosts. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2014
Merged

Check against basestring instead of str in collect.hosts. #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def collect_hosts(hosts, randomize=True):
randomize the returned list.
"""

if isinstance(hosts, str):
if isinstance(hosts, basestring):
hosts = hosts.strip().split(',')

result = []
Expand Down
10 changes: 10 additions & 0 deletions test/test_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,16 @@ def test_init_with_csv(self):
[('kafka01', 9092), ('kafka02', 9092), ('kafka03', 9092)],
client.hosts)

def test_init_with_unicode_csv(self):

with patch.object(KafkaClient, 'load_metadata_for_topics'):
client = KafkaClient(
hosts=u'kafka01:9092,kafka02:9092,kafka03:9092')

self.assertItemsEqual(
[('kafka01', 9092), ('kafka02', 9092), ('kafka03', 9092)],
client.hosts)

def test_send_broker_unaware_request_fail(self):
'Tests that call fails when all hosts are unavailable'

Expand Down