Skip to content

Make seek(); commit(); work without commit discarding the seek change #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2014
Merged

Make seek(); commit(); work without commit discarding the seek change #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5af317
Make seek(); commit(); work without commit discarding the seek change
Mar 25, 2014
7d425d0
Commit in seek if autocommit
Mar 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kafka/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,10 @@ def seek(self, offset, whence):

# Reset queue and fetch offsets since they are invalid
self.fetch_offsets = self.offsets.copy()
if self.auto_commit:
self.count_since_commit += 1
self.commit()

self.queue = Queue()

def get_messages(self, count=1, block=True, timeout=0.1):
Expand Down