Mock dns lookups in test_conn #1739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Mar 14, 2019
| @@ -25,7 +32,7 @@ def _socket(mocker): | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def conn(_socket): | |||
| def conn(_socket, dns_lookup): | |||
There was a problem hiding this comment.
Took me a moment to realize this fixture always provides a localhost... it'd be nice if there was a docstring explaining what this fixture is intended for and what it provides.
That's a more general comment about our fixtures though, as I've slowly waded through #1193 it's taken longer than it should have to follow the fixture paths because they aren't documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to avoid doing dns resolution when running local connection tests.
This change is