KIP-70: Auto-commit offsets on consumer.unsubscribe(), defer assignment changes to rejoin #2560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
reviewed
Mar 26, 2025
Comment on lines
+5
to
+7
| from collections import Sequence | ||
| except ImportError: | ||
| from collections.abc import Sequence |
There was a problem hiding this comment.
This causes DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
I think the imports should be reversed here:
Suggested change
| from collections import Sequence | |
| except ImportError: | |
| from collections.abc import Sequence | |
| from collections.abc import Sequence | |
| except ImportError: | |
| from collections import Sequence |
Or possibly just replace the entire try/except with a single import since the other import is only valid on very old/outdated Pythons.
from collections.abc import SequenceThere was a problem hiding this comment.
thanks, yea we still support very old pythons (2.7). I did try old, except new but that does cause deprecation warnings for interim pythons. I can see how you might prefer try new, except old
millerdev
added a commit
to dimagi/commcare-hq
that referenced
this pull request
Mar 26, 2025
millerdev
added a commit
to dimagi/commcare-hq
that referenced
this pull request
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1242