Skip to content

allow for timeout to be None in SimpleConsumer.get_messages #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2013
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kafka/consumer.py
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,8 @@ def get_messages(self, count=1, block=True, timeout=0.1):
iterator = self.__iter__()

# HACK: This splits the timeout between available partitions
timeout = timeout * 1.0 / len(self.offsets)
if timeout:
timeout = timeout * 1.0 / len(self.offsets)

with FetchContext(self, block, timeout):
while count > 0:
Expand Down