Allow unicode_set_filter in IcuNormalizationCharFilter

[burakfahri]

Java API client version

8.16.1

Java version

21

Elasticsearch Version

8.13.4

Problem description

In IcuNormatlizationChatFilter class, there is no field called unicode_set_filter. We use it to control which letters are normalized(documentation: https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-normalization-charfilter.html). The exception that we get is like the following:

Caused by: co.elastic.clients.json.JsonpMappingException: Error deserializing 
co.elastic.clients.elasticsearch._types.analysis.IcuNormalizationCharFilter: Unknown field 'unicode_set_filter' (JSON path: template.settings.analysis.char_filter.custom_icu_normalizer.unicode_set_filter) (in object at line no=1910, column no=38, offset=57197)
		at co.elastic.clients.json.ObjectDeserializer.parseUnknownField(ObjectDeserializer.java:291)
		at co.elastic.clients.json.ObjectDeserializer.deserializeInner(ObjectDeserializer.java:212)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:166)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:157)
		at co.elastic.clients.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:77)
		at co.elastic.clients.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:79)
		at co.elastic.clients.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:43)
		at co.elastic.clients.json.ObjectDeserializer$FieldObjectDeserializer.deserialize(ObjectDeserializer.java:78)
		at co.elastic.clients.json.ObjectDeserializer.deserializeInner(ObjectDeserializer.java:231)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:166)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:157)
		at co.elastic.clients.json.BuildFunctionDeserializer.deserialize(BuildFunctionDeserializer.java:53)
		at co.elastic.clients.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:48)
		at co.elastic.clients.json.UnionDeserializer$SingleMemberHandler.deserialize(UnionDeserializer.java:74)
		at co.elastic.clients.json.UnionDeserializer.deserialize(UnionDeserializer.java:287)
		at co.elastic.clients.json.UnionDeserializer.deserialize(UnionDeserializer.java:258)
		at co.elastic.clients.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:43)
		at co.elastic.clients.json.JsonpDeserializerBase$StringMapDeserializer.deserialize(JsonpDeserializerBase.java:349)
		at co.elastic.clients.json.JsonpDeserializerBase$StringMapDeserializer.deserialize(JsonpDeserializerBase.java:333)
		at co.elastic.clients.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:77)
		at co.elastic.clients.json.ObjectDeserializer$FieldObjectDeserializer.deserialize(ObjectDeserializer.java:78)
		at co.elastic.clients.json.ObjectDeserializer.deserializeInner(ObjectDeserializer.java:214)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:166)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:157)
		at co.elastic.clients.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:77)
		at co.elastic.clients.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:79)
		at co.elastic.clients.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:43)
		at co.elastic.clients.json.ObjectDeserializer$FieldObjectDeserializer.deserialize(ObjectDeserializer.java:78)
		at co.elastic.clients.json.ObjectDeserializer.deserializeInner(ObjectDeserializer.java:214)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:166)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:157)
		at co.elastic.clients.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:77)
		at co.elastic.clients.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:79)
		at co.elastic.clients.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:43)
		at co.elastic.clients.json.ObjectDeserializer$FieldObjectDeserializer.deserialize(ObjectDeserializer.java:78)
		at co.elastic.clients.json.ObjectDeserializer.deserializeInner(ObjectDeserializer.java:214)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:166)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:157)
		at co.elastic.clients.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:77)
		at co.elastic.clients.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:79)
		at co.elastic.clients.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:43)
		at co.elastic.clients.json.ObjectDeserializer$FieldObjectDeserializer.deserialize(ObjectDeserializer.java:78)
		at co.elastic.clients.json.ObjectDeserializer.deserializeInner(ObjectDeserializer.java:214)
		at co.elastic.clients.json.ObjectDeserializer.deserialize(ObjectDeserializer.java:166)
		at co.elastic.clients.util.WithJsonObjectBuilderBase.withJson(WithJsonObjectBuilderBase.java:54)
		at com.meltwater.es.ESClientImpl$putTemplate$1.invoke$lambda$0(ESClientImpl.kt:362)
		at co.elastic.clients.elasticsearch.indices.ElasticsearchIndicesAsyncClient.putIndexTemplate(ElasticsearchIndicesAsyncClient.java:1615)

[burakfahri]

I have a PR to fix the problem: elastic/elasticsearch-specification#4275

[l-trotta]

hey @burakfahri thanks for the report and fix! someone will take care of this in the specification repo, then we'll regenerate the java client to fix the issue

[burakfahri]

Hello @l-trotta, let me know if I can do anything more about it please

[burakfahri]

Hello @l-trotta , do you know when are you going to regenerate the new java client with the new fixes? Correct me if I am wrong, but I see that the PR that is merged will be back ported on version 8.17 and 8.18. I still can not see the changes on the code: https://github.com/elastic/elasticsearch-java/blob/v8.18.1/java-client/src/main/java/co/elastic/clients/elasticsearch/_types/analysis/IcuNormalizationCharFilter.java

[l-trotta]

Hey @burakfahri, yes the java client wasn't regenerated yet since the PR with the fix was merged, my mistake, I was sure I included it in the latest releases. Next releases will be early next week, and the fix will be there for sure :)