CommonTermsQuery Parses Incorrectly

[rlhotovy]

I tried executing a CommonTermsQuery using the following code:

[Fact]
public void TestQuery()
{
    // method to get a client with correct connection settings
    var client = GetElasticClient();

    var result = client.Search<IndexedTeam>(s => s
        .Query(q => q
            .CommonTerms(t => t
                .OnField("name")
                .Query("Huskers"))));
    Assert.True(result.Hits.Any());
}

and the query returned no results. Using a REST client, I manually sent a post query with the following body to the same instance of Elasticsearch and received several results:

{
  "query" : {
    "common" : {
      "name" : {
        "query" : "Huskers"
      }
    }
  }
}

and I received many results. I believe the issue is in this line. The PropertyName should be "common" so that it matches the Elasticsearch specs. I've cloned the repo locally and tried making this change on my side and it seems to fix the issue, but I wanted to see if anyone else had reported this or noticed it before submitting a pull request. Thanks in advance for you response!

[gmarz]

@rlhotovy This definitely looks like a bug. Probably went unnoticed for this long because the common terms query isn't so common :).

Thank you for the excellent reporting and for already attempting a fix 👍. Please feel free to submit a PR for this (and sign the CLA) and we'll gladly merge it in.

[gmarz]

@rlhotovy We went ahead and fixed this since we want to get a release out today. Thanks again for reporting, and we'll be looking forward to future PRs :).

[rlhotovy]

Awesome. This was the third thing on my list of things to do today, so that's convenient. Thanks for your quick response to this issue!