Cannot use RawJsonQuery

[gpetrou]

Elastic.Clients.Elasticsearch version: 8.13.10

Elasticsearch version: 8.13.2

.NET runtime version: 8.0

Operating system version:

Description of the problem including expected versus actual behavior:
Try to execute the following code:

Elastic.Clients.Elasticsearch.QueryDsl.RawJsonQuery rawQuery = new("{\"term\": { \"fieldname\": \"value\"  }}");

SearchRequest<JsonObject> elasticSearchRequest = new("IndexName")
{
    Query = rawQuery
};

Elastic.Clients.Elasticsearch.SearchResponse<JsonObject> expected = await _elasticsearchClient.SearchAsync<JsonObject>(elasticSearchRequest);

It results in:

{
  "query": {
    "raw_json": {"term": { "fieldname": "value"  }}
  }
}

Therefore there is a parsing_exception.

Steps to reproduce:
1.
2.
3.

Expected behavior
A clear and concise description of what you expected to happen.

Provide ConnectionSettings (if relevant):

Provide DebugInformation (if relevant):

[gpetrou]

@flobernd looks like the issue is in one of your generated files, so I cannot just change that. Can you please fix it? I assume that for raw json, we shouldn't use writer.WriteStartObject();, writer.WritePropertyName(value.VariantName);, etc...

[flobernd]

Hi @gpetrou,

the RawJsonQuery is a bit of a hack. The most easiest fix for me would be to separate the variant-name (e.g. "term") from the rest of the query payload:

var q = new RawJsonQuery("term", "{ \"fieldname\": \"value\"  }");

Would that work for you?

---

Special handling in the generator is possible, but I'd like to avoid that.

Btw.: In general you should prefer not using the RawJsonQuery, if the functionality is otherwise supported in the client. This construct was only added as a last-resort fallback when the client was still lacking a lot of features. Is there a specific reason for using RawJsonQuery in your case? I'm curious if I can "properly" improve things to simplify your use-case.

[gpetrou]

There are still cases such as #8169 (comment) where this seems to be needed. I would expect this to work similarly to Nest.RawQuery.

[flobernd]

Yes, this case would work.

[tabareh]

Hi @gpetrou,

the RawJsonQuery is a bit of a hack. The most easiest fix for me would be to separate the variant-name (e.g. "term") from the rest of the query payload:

var q = new RawJsonQuery("term", "{ \"fieldname\": \"value\"  }");

Would that work for you?

Special handling in the generator is possible, but I'd like to avoid that.

Btw.: In general you should prefer not using the RawJsonQuery, if the functionality is otherwise supported in the client. This construct was only added as a last-resort fallback when the client was still lacking a lot of features. Is there a specific reason for using RawJsonQuery in your case? I'm curious if I can "properly" improve things to simplify your use-case.

There is well no RawJsonQuery constructor that accepts two params at least for version 8.13.12 that I use

[flobernd]

@tabareh Yes, this will be available after I released a fix.

[andrewrauber]

@flobernd do we have an update on a fix for this?
Using RawJsonQuery seems to be our only option given that GeoShapeQuery doesn't exist yet.
Our last resort would be to convert everything to Nest, which is not ideal.

[flobernd]

@andrewrauber If it's only about the GeoShapeQuery, I can offer to include it in the next release. The Shape property would be of type object which means you have to create your own shape classes, but I guess that would help?

[andrewrauber]

@flobernd Yes, that works for me, assuming the next release is in the coming week or so?

[flobernd]

@andrewrauber GeoShapeQuery and ShapeQuery is now available with the release of 8.14.7.

[andrewrauber]

Amazing!
Thank you so much.