Skip to content

Fix handling of return types. #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Fix handling of return types. #1887

merged 1 commit into from
Mar 3, 2016

Conversation

rossbrower
Copy link
Contributor

Calling a method on the low level client with Stream, VoidResponse, etc. fails with a NullReferenceException. This change fixes the reflection calls which (while seemingly correct) do not work at runtime.

@gmarz
Copy link
Contributor

gmarz commented Mar 3, 2016

Yikes! cs.Body is null in this case and the is operator only works on non-null expressions.

Nice find @rossbrower and thanks for the PR. 👍

@gmarz gmarz added Bug labels Mar 3, 2016
gmarz added a commit that referenced this pull request Mar 3, 2016
Fix handling of return types.
@gmarz gmarz merged commit 236ef25 into elastic:master Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants