Skip to content

Fix CI #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Fix CI #84

merged 4 commits into from
Oct 10, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 12, 2024

Closes #62

So most errors fixed themselves at some point. However, test_ignore_error_if_raised became flaky. I think there was a race where either 42 or "c" could win. And if "c" won, then 42 was coerced into a string, which meant the test did not fail as expected. Adding an explicit mapping fixed this. I also added notifications to be alerted of failure.

@pquentin pquentin force-pushed the remove-xfail branch 2 times, most recently from 6efb151 to 300296e Compare October 10, 2024 11:19
@pquentin pquentin changed the title Remove xfails as tests appear to pass now Fix CI Oct 10, 2024
@pquentin pquentin merged commit 9f1e03c into elastic:main Oct 10, 2024
11 checks passed
@pquentin pquentin self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix async bulk failures
2 participants