Skip to content

Regression on AggregationRange - incorrect types for from and to fields #2641

Closed
@pgayvallet

Description

@pgayvallet

🐛 Wrong type

AggregationRange.from and AggregationRange.to were changed from string | number to number in #2552

From the PR:

AggregationRange accepting both double and string was probably established because at some point it was also used for RangeQuery, which accepts Objects for parameters to and from. But in the spec we just use it in GeoDistanceAggregation and RangeAggregation, both accepting only doubles. Since the java client generalizes string | double as just string, this results in the server throwing exceptions when called.

This was supposed to be done to address elastic/elasticsearch-java#666, but the assumption that was used for the PR is wrong, For RangeAggrations at least, from and to do support string type value, for patterns such as now or now+X.

E.g from the Kibana repo:

https://github.com/elastic/kibana/blob/1c1e20afdb883fc279c5a06d4b71f8e577f8dad6/x-pack/plugins/task_manager/server/monitoring/workload_statistics.ts#L169-L180

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions