-
Notifications
You must be signed in to change notification settings - Fork 97
Update API spec from results of the Java flight records loader #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -75,7 +61,7 @@ export class AggregationProfileDelegateDebugFilter { | |||
} | |||
|
|||
export class AggregationProfile { | |||
breakdown: AggregationBreakdown | |||
breakdown: Dictionary<string, long> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it a generic dictionary since this is what it is on the ES server, and the field names evolve quite often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice if we could ship the spec with an AggregrationBreakdownKeys
that encodes known key constants into these dictionaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer the breakdowns as objects here over dictionaries since my understanding is the values aren't variable? Otherwise LGTM
I've reverted the changes to breakdowns, so that we can move forward with the other changes and take the time to think carefully about them. I've opened #2021 for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2019-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 94dced0edf8426138a83c8ff5ee7b33e25280ace
# Push it to GitHub
git push --set-upstream origin backport-2019-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
A collection or API spec fixes using flight-recorder recordings from a recent 8.7.0 snapshot and running them through the Java client's flight recordings validator. This validator is more strict than our JS/TS validator, and also reports unknown fields.
I've added the
backport 7.17
label, even if only a limited number of fixes actually apply to that branch. I'll cherry-pick those that are relevant.