Add shards_capacity to health_report #2146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
7 tasks
swallez
approved these changes
Jun 23, 2023
Comment on lines
+177
to
+180
| export class ShardsCapacityIndicatorDetails { | ||
| data: ShardsCapacityIndicatorTierDetail | ||
| frozen: ShardsCapacityIndicatorTierDetail | ||
| } |
There was a problem hiding this comment.
This pattern where all fields are of the same type could also be a Dictionary<string, SomeType> to allow for future expansion, or also to account for values we haven't seen in the docs or tests.
In this particular case, looking at the ES code shows that these are hardcoded constants that are unlikely to have new members. So this approach works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
shards_capacityto the health API.My first time making a spec change so let me know if I missed anything important here. 🙏
Done per @rudolf's needs mentioned in elastic/kibana#159587 (comment).