Skip to content

Add descriptions for cluster settings and cluster stats #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 26, 2023

Relates to #964

This PR adds descriptions for the cluster settings and cluster stats endpoints. It also sorts the properties into alphabetic order since that seems to currently affect how they're sorted in the OAS.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cluster.get_settings 🟢 7/7 7/7
cluster.stats 🟢 8/8 8/8

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review June 26, 2023 14:43
@lcawl lcawl requested a review from abdonpijpelink June 26, 2023 14:44
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit f6bc6c6 into main Jun 28, 2023
@lcawl lcawl deleted the cluster-settings branch June 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants