Skip to content

Add descriptions for index settings APIs #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jul 7, 2023

Adds descriptions for the following APIs:

  • Get index settings API
  • Put index settings API

This PR doesn't update index setting descriptions. I have an open request regarding setting type annotations I'd like to resolve first.

Source for descriptions

Source for the descriptions:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.get_settings 🔴 54/54 50/54
indices.put_settings 🔴 46/48 48/48

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 7994247 into main Jul 11, 2023
@jrodewig jrodewig deleted the add-descriptions-for-index-settings-apis branch July 11, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants