Add descriptions for queries H-Q #2213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
suggested changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks for putting this up!
It looks like one of the parameter values is missing some text (#2213 (comment)). I'm also not sure how we're handling formatting for fields without explicit keys (such as <field>).
Other than that, this looks good to me. I left several non-blocking nits that you can ignore if wanted.
Co-authored-by: James Rodewig <[email protected]>
64 tasks
|
Thanks for the thorough review @jrodewig . I've pushed a change that applies your suggestions. |
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #964
Adds Query DSL descriptions for queries H through Q. Descriptions were sourced from https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl.html and subpages.