Skip to content

Renamed synonyms API namespaces #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2023
Merged

Renamed synonyms API namespaces #2234

merged 2 commits into from
Aug 11, 2023

Conversation

carlosdelest
Copy link
Member

@carlosdelest carlosdelest commented Aug 11, 2023 •
edited
Loading

Renaming synonyms API specs according to elastic/elasticsearch#98364.

This is a follow-up PR for elastic/elasticsearch#98383, and must be merged after that one.

Closes elastic/elasticsearch#98364

@carlosdelest carlosdelest mentioned this pull request Aug 11, 2023
Closed
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule ⚪ Missing test Missing test
synonyms.delete_synonym ⚪ Missing test Missing test
synonyms.get_synonym_rule ⚪ Missing test Missing test
synonyms.get_synonym ⚪ Missing test Missing test
synonyms.get_synonyms_sets ⚪ Missing test Missing test
synonyms.put_synonym_rule ⚪ Missing test Missing test
synonyms.put_synonym ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

swallez
swallez approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlosdelest carlosdelest marked this pull request as ready for review August 11, 2023 10:45
@carlosdelest carlosdelest requested a review from a team as a code owner August 11, 2023 10:45
@swallez swallez mentioned this pull request Aug 11, 2023
Merged
@carlosdelest carlosdelest merged commit 82a3e5f into main Aug 11, 2023
@carlosdelest carlosdelest deleted the carlosdelest/synonyms-api-namespace-rename branch August 11, 2023 11:47
@swallez swallez mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group all synonym APIs under a single namespace in the rest-api-spec
2 participants
@carlosdelest @swallez