-
Notifications
You must be signed in to change notification settings - Fork 98
[DOCS] Adds descriptions to ingest APIs #2236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job going through every parameter of every processor!
LGTM. I've left a few suggestions.
Co-authored-by: Abdon Pijpelink <[email protected]>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
@@ -11692,7 +11692,7 @@ export interface IngestUppercaseProcessor extends IngestProcessorBase { | |||
|
|||
export interface IngestUrlDecodeProcessor extends IngestProcessorBase { | |||
field: Field | |||
ignore_missing?: boolean | |||
ignre_missing?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szabosteve @abdonpijpelink is this change intentional? just noticed it when spot-checking the latest JS code generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshMock No, it is not intentional. It's an error. Thanks for spotting it! I'll open a PR to fix it soon!
Overview
Related to #964.
Adds descriptions to ingest API properties. Source of info: https://www.elastic.co/guide/en/elasticsearch/reference/master/ingest-apis.html