Skip to content

adding _rank to hit, fix property name #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

l-trotta
Copy link
Contributor

Originally reported on discuss.
Hit is missing the optional _rank field -> server code
Also window_size in Rank was recently changed to rank_window_size -> commit

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2124/2205 2139/2187

You can validate this API yourself by using the make validate target.

@l-trotta l-trotta merged commit 177dfd3 into main Jul 16, 2024
7 checks passed
@l-trotta l-trotta deleted the missing_rank_from_hit branch July 16, 2024 11:02
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
l-trotta added a commit that referenced this pull request Jul 16, 2024
(cherry picked from commit 177dfd3)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants