Optional fields in term vector res #2724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
flobernd
approved these changes
Jul 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
(cherry picked from commit 5615a46)
l-trotta
added a commit
that referenced
this pull request
Jul 16, 2024
(cherry picked from commit 5615a46) Co-authored-by: Laura Trotta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(MtermVector and TermVector have the same response class in the server code, in the spec we have them separate because of json formatting I think)
reported in java client issue 838:
field_statisticsis not present in response if specified so in request (settingfield_statisticsasfalse). server code logic seems to be that iffield_statisticswasn't requested, thendoc_countwill be set as-1, which will omit building the field in the response.reported in java client issue 839
idis not present in the response if the request was made with an artificial document. server code