-
Notifications
You must be signed in to change notification settings - Fork 99
[Connectors API] Fix advanced snippet value type #3025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connectors API] Fix advanced snippet value type #3025
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (to be fair it was originally spotted by @Anaethelion)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-3025-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82461ccded3b202c4c24aed47ef79057bc41c0fc
# Push it to GitHub
git push --set-upstream origin backport-3025-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15 Then, create a pull request where the |
(cherry picked from commit 82461cc)
(cherry picked from commit 82461cc)
(cherry picked from commit 82461cc) Co-authored-by: Jedr Blaszyk <[email protected]>
(cherry picked from commit 82461cc) Co-authored-by: Jedr Blaszyk <[email protected]>
Changes
Fix type mismatch between definition in ES, in ES we define the advancedSnippet value as
Object
, see code referenceThis is because this can be either object or array of objects. Changing
Dictionary<string, UserDefinedValue>
toUserDefinedValue
Shoutout to @l-trotta for spotting the issue! 🏅